feat: model max_length_unit on SchemaDiscoveryColumn - #47
Merged
Conversation
cph-datamasque
previously requested changes
Sep 9, 2026
cph-datamasque
left a comment
cph-datamasque
left a comment
Collaborator
There was a problem hiding this comment.
Library changes are fine, just one comment re the CI change
elliotsimpson-dm
force-pushed
the
DM-4587-model-max-length-unit
branch
from
September 9, 2026 01:26
321a2fa to
51bc7cf
Compare
The schema-discovery API now returns a max_length_unit field per column (server 3.26.17), which the drift guard in the dm-python live tests flagged as unmodelled. Add a LengthUnit enum (chars/bytes) and the optional field, export it, bump to 1.2.6, and record the change.
Add a github-release job to release.yml that, after the PyPI publish succeeds, creates the GitHub Release for the pushed tag, attaches the built distributions, and links to HISTORY.rst at that tag for the changelog (rather than autogenerated git-diff notes). Drop the now-obsolete manual GitHub Release steps from RELEASING.rst.
elliotsimpson-dm
force-pushed
the
DM-4587-model-max-length-unit
branch
from
September 9, 2026 02:01
51bc7cf to
1f3c72b
Compare
cph-datamasque
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema-discovery API now returns a max_length_unit field per column (server 3.26.17), which the drift guard in the dm-python live tests flagged as unmodelled. Add a LengthUnit enum (chars/bytes) and the optional field, export it, bump to
1.2.61.3.1, and record the change.